proxy_* params were removed from class apt #443
Merged
+75
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,6 +5,8 @@ | |||
| $options = $::apt::ppa_options, | |||
| $package_name = $::apt::ppa_package, | |||
| $package_manage = false, | |||
| $proxy_host = undef, | |||
| $proxy_port = 8080, | |||
There was a problem hiding this comment.
Mmm, I've started disliking having multiple variables that are an obvious pair/entity as multiple switches on the class and instead have taken to doing something like this:
class apt::params {
$proxy = { 'host': undef, 'port': 8080 }
}
define apt::ppa (
$proxy = {}
) {
$_proxy = merge($apt::proxy, $proxy)
}This allows the user to still only specify proxy => { 'host': '127.0.0.1' } and get the port for free.
What do you think?
There was a problem hiding this comment.
No, I've just been doing too much of non-Ruby/Puppet as of late. I meant hash rockets.
There was a problem hiding this comment.
Ok, cool, just wanted to make sure I didn't miss something new :) I'll get this updated.
underscorgan
force-pushed
the
proxy_updates
branch
from
8184376 to
16d9560
Compare
|
Mmm, we actually have no tests covering this change. |
Add them to PPA since they were being used there, and add a placeholder example for setting up the proxy files.
underscorgan
force-pushed
the
proxy_updates
branch
from
16d9560 to
3e44b68
Compare
daenney
added a commit
that referenced
this pull request
Feb 26, 2015
proxy_* params were removed from class apt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add them to PPA since they were being used there, and add a placeholder
example for setting up the proxy files.